fix(AjaxObservable): drop resultSelector support in ajax method#1813
Merged
jayphelps merged 1 commit intoReactiveX:masterfrom Jul 17, 2016
Merged
fix(AjaxObservable): drop resultSelector support in ajax method#1813jayphelps merged 1 commit intoReactiveX:masterfrom
jayphelps merged 1 commit intoReactiveX:masterfrom
Conversation
Member
Author
|
/cc @david-driscoll for visibility. |
Member
|
LGTM |
kwonoj
force-pushed
the
ajax-resultselector
branch
from
5a9ca15 to
ed60a4c
Compare
kwonoj
force-pushed
the
ajax-resultselector
branch
from
ed60a4c to
cbce3b6
Compare
kwonoj
force-pushed
the
ajax-resultselector
branch
from
cbce3b6 to
786d05e
Compare
kwonoj
force-pushed
the
ajax-resultselector
branch
from
786d05e to
f962287
Compare
kwonoj
force-pushed
the
ajax-resultselector
branch
from
f962287 to
6988a3d
Compare
Member
|
LGTM |
Member
|
Needs rebase, then I'll merge. Ping me. |
closes ReactiveX#1783 BREAKING CHANGE: ajax.*() method no longer support resultSelector, encourage to use `map` instead
kwonoj
force-pushed
the
ajax-resultselector
branch
from
6988a3d to
7a77437
Compare
Member
Author
|
Thanks, rebased. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR drops support of
resultSelectorinajax*()mehod.resultSelector, ajax method delivers strictAjaxResponsetype resolve type inference issues on subscription.mapas necessary.Related issue (if exists):
closes #1783
BREAKING CHANGE: ajax.*() method no longer support resultSelector, encourage to use
mapinstead